From a7dc98ee74cd9b77c66598072afde5f794400041 Mon Sep 17 00:00:00 2001 From: sm4640 Date: Sat, 12 Apr 2025 15:53:55 +0900 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fix:=20[#30]=20check=5Fuser=5Fpo?= =?UTF-8?q?rtfolio=5Frel=20=EC=8B=9C=20try=20except?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- portfolios/views.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/portfolios/views.py b/portfolios/views.py index a7a2e08..00d33ed 100644 --- a/portfolios/views.py +++ b/portfolios/views.py @@ -77,8 +77,11 @@ class PortfolioChangeState(APIView): portfolio = get_object_or_404(Portfolio, pk=pk) user = request.user action_type = request.query_params.get('type') - if PortfolioBeforeRelCheckService.check_user_portfolio_rel(action_type, portfolio, user): - return Response({"message": "already done"}, status=status.HTTP_400_BAD_REQUEST) + try: + if PortfolioBeforeRelCheckService.check_user_portfolio_rel(action_type, portfolio, user): + return Response({"message": "already done"}, status=status.HTTP_400_BAD_REQUEST) + except ValueError as e: + return Response({'message': str(e)}, status=status.HTTP_400_BAD_REQUEST) return self._handle_action(action_type, portfolio, user, add=True) @transaction.atomic @@ -86,8 +89,11 @@ class PortfolioChangeState(APIView): portfolio = get_object_or_404(Portfolio, pk=pk) user = request.user action_type = request.query_params.get('type') - if not PortfolioBeforeRelCheckService.check_user_portfolio_rel(action_type, portfolio, user): - return Response({"message": "never done before"}, status=status.HTTP_400_BAD_REQUEST) + try: + if not PortfolioBeforeRelCheckService.check_user_portfolio_rel(action_type, portfolio, user): + return Response({"message": "never done before"}, status=status.HTTP_400_BAD_REQUEST) + except ValueError as e: + return Response({'message': str(e)}, status=status.HTTP_400_BAD_REQUEST) return self._handle_action(action_type, portfolio, user, add=False) def _handle_action(self, action_type, portfolio, user, add=True):